RFR: 8343481: Remove unnecessary @SuppressWarnings annotations (kulla) [v5]
Archie Cobbs
acobbs at openjdk.org
Tue Nov 19 22:48:18 UTC 2024
On Wed, 13 Nov 2024 16:53:03 GMT, Archie Cobbs <acobbs at openjdk.org> wrote:
>> Please review this patch which removes unnecessary `@SuppressWarnings` annotations.
>
> Archie Cobbs has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains seven additional commits since the last revision:
>
> - Merge branch 'master' into SuppressWarningsCleanup-kulla
> - Merge branch 'master' into SuppressWarningsCleanup-kulla
> - Update copyright years.
> - Merge branch 'master' into SuppressWarningsCleanup-kulla
> - Remove two more "this-escape" supressions.
> - Merge branch 'master' into SuppressWarningsCleanup-kulla
> - Remove unnecessary @SuppressWarnings annotations.
Question for @lahodaj ... I'm realizing now that most of the files patched here are imports from JLine.
Is it important to minimize changes to these imported files? If so I can revert the JLine changes in this patch; there would then only be two patched files in `jdk.jshell` remaining.
Thanks.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/21855#issuecomment-2486880435
More information about the kulla-dev
mailing list