RFR: 8343481: Remove unnecessary @SuppressWarnings annotations (kulla) [v5]

[Archie Cobbs]

On Wed, 20 Nov 2024 15:24:32 GMT, Archie Cobbs <acobbs at openjdk.org> wrote:

> > Ideally, the changes could be contributed to JLine, and we would adopt them at some point as part of a JLine upgrade.
> 
> I'll work on that.

Hah, that doesn't work - in the JDK the imported JLine code is built as part of an internal module, so the `this-escape` warning does not apply to the classes where it's being suppressed, unlike in the normal JLine build.

So eventually if/when the `suppression` warning becomes active we'll just do something like this instead...

--- a/make/modules/jdk.internal.le/Java.gmk
+++ b/make/modules/jdk.internal.le/Java.gmk
@@ -23,6 +23,6 @@
 # questions.
 #
 
-DISABLED_WARNINGS_java += dangling-doc-comments this-escape
+DISABLED_WARNINGS_java += dangling-doc-comments this-escape suppression
 
 COPY += .properties .caps .txt

-------------

PR Comment: https://git.openjdk.org/jdk/pull/21855#issuecomment-2488940711