RFR: 8341495: JShell crashes with java.util.MissingFormatArgumentException [v2]

[Archie Cobbs]

On Fri, 4 Oct 2024 13:43:58 GMT, Chen Liang <liach at openjdk.org> wrote:

>> Archie Cobbs has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Fix  prefixing/postfixing logic broken by previous commit.
>
> src/jdk.jshell/share/classes/jdk/internal/jshell/tool/JShellTool.java line 839:
> 
>> 837:      * @return the pre/post-fixed and bracketed format string
>> 838:      */
>> 839:     String prefix(String s, String pre, String post) {
> 
> Shouldn't this `s` be renamed to `format` too, if you perform such a rename?

Yes, thanks. Fixed in 4e692b457db.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21339#discussion_r1787858825