RFR: 8350983: JShell LocalExecutionControl only needs stopCheck() on backward branches [v2]

Chen Liang liach at openjdk.org
Tue Apr 1 00:26:11 UTC 2025


On Mon, 3 Mar 2025 15:19:22 GMT, Archie Cobbs <acobbs at openjdk.org> wrote:

>> JShell's `LocalExecutionControl` ensures a running eval thread can be stopped by `JShell.stop()` by inserting an invocation of `stopCheck()` at every branch point in the bytecode of loaded classfiles.
>> 
>> However, this same guarantee can be provided by invoking `stopCheck()` only at backward branches and not at forward branches. By doing this, the performance and size impact on the executing code can be reduced.
>> 
>> Fortunately the new ClassFile API makes this kind of modification easy 👍
>
> Archie Cobbs has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Niceify using pattern matching switch with guard per review suggestion.

@lahodaj Can you take a look at this?

-------------

PR Comment: https://git.openjdk.org/jdk/pull/23850#issuecomment-2767706000


More information about the kulla-dev mailing list