RFR: 8301991: Convert l10n properties resource bundles to UTF-8 native [v2]
Justin Lu
jlu at openjdk.org
Thu Apr 10 18:47:53 UTC 2025
On Thu, 10 Apr 2025 08:44:28 GMT, Eirik Bjørsnøs <eirbjo at openjdk.org> wrote:
>> Justin Lu has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Replace InputStreamReader with BufferedReader
>
> FWIW, I checked out the revision of the commit previous to this change and found the following:
>
>
> % git checkout b55e418a077791b39992042411cde97f68dc39fe^
> % find src -name "*.properties" | xargs file | grep -v ASCII
> src/java.xml/share/classes/com/sun/org/apache/xml/internal/serializer/Encodings.properties:
> ISO-8859 text
> src/java.xml.crypto/share/classes/com/sun/org/apache/xml/internal/security/resource/xmlsecurity_de.properties:
> Unicode text, UTF-8 text, with very long lines (322)
>
>
> Which indicates that that this is the only non-ASCII, non-UTF-8 property file. So we may be lucky.
This conversion was performed under the assumption of ASCII set and Unicode escape sequences, which is the format we expect for the translation process for .properties files. That file should have been omitted from this change. Thank you @eirbjo and @magicus for the analysis and checking!
-------------
PR Comment: https://git.openjdk.org/jdk/pull/15694#issuecomment-2794828598
More information about the kulla-dev
mailing list