RFR: 8350983: JShell LocalExecutionControl only needs stopCheck() on backward branches [v3]
Hannes Greule
hgreule at openjdk.org
Tue Apr 22 14:30:42 UTC 2025
On Tue, 22 Apr 2025 14:17:57 GMT, Archie Cobbs <acobbs at openjdk.org> wrote:
>> JShell's `LocalExecutionControl` ensures a running eval thread can be stopped by `JShell.stop()` by inserting an invocation of `stopCheck()` at every branch point in the bytecode of loaded classfiles.
>>
>> However, this same guarantee can be provided by invoking `stopCheck()` only at backward branches and not at forward branches. By doing this, the performance and size impact on the executing code can be reduced.
>>
>> Fortunately the new ClassFile API makes this kind of modification easy 👍
>
> Archie Cobbs has updated the pull request incrementally with one additional commit since the last revision:
>
> Style improvements based on review comments.
I'm not sure how this can be tested easily, but does the change deal with recursion properly?
-------------
PR Comment: https://git.openjdk.org/jdk/pull/23850#issuecomment-2821522382
More information about the kulla-dev
mailing list