RFR: 8350983: JShell LocalExecutionControl only needs stopCheck() on backward branches [v3]
Jan Lahoda
jlahoda at openjdk.org
Tue Apr 22 15:37:49 UTC 2025
On Tue, 22 Apr 2025 14:27:41 GMT, Hannes Greule <hgreule at openjdk.org> wrote:
> I'm not sure how this can be tested easily, but does the change deal with recursion properly?
I don't think the cancel in the local execution handles recursion, neither the current nor the revised version. But, as @liach says, the VM will fail with StackOverflowError in case of infinite recursion, so the cancel there is not so critical.
Overall, the cancel is best effort in any case. For local execution, the danger it won't work is a bit higher, but there's only so much we can do about it.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/23850#issuecomment-2821718867
More information about the kulla-dev
mailing list