From sven.reimers at gmail.com Sun Feb 2 17:33:14 2025 From: sven.reimers at gmail.com (Sven Reimers) Date: Sun, 2 Feb 2025 18:33:14 +0100 Subject: User supplied JavaDoc Message-ID: Hi, Any chance anybody can look into https://bugs.openjdk.org/browse/JDK-8186876 ? For usages like JTaccuino and maybe jjava kernel this will be very useful. Thanks for checking Sven -------------- next part -------------- An HTML attachment was scrubbed... URL: From davidalayachew at gmail.com Sun Feb 2 20:03:30 2025 From: davidalayachew at gmail.com (David Alayachew) Date: Sun, 2 Feb 2025 15:03:30 -0500 Subject: User supplied JavaDoc In-Reply-To: References: Message-ID: I think this would be useful too. Even if it is super limited, simply having the option gives us a lot of flexibility. On Sun, Feb 2, 2025, 12:33?PM Sven Reimers wrote: > Hi, > > Any chance anybody can look into > https://bugs.openjdk.org/browse/JDK-8186876? > > For usages like JTaccuino and maybe jjava kernel this will be very useful. > > Thanks for checking > > Sven > > -------------- next part -------------- An HTML attachment was scrubbed... URL: From liach at openjdk.org Tue Feb 4 15:55:11 2025 From: liach at openjdk.org (Chen Liang) Date: Tue, 4 Feb 2025 15:55:11 GMT Subject: RFR: 8347629: Test FailOverDirectExecutionControlTest.java fails with -Xcomp In-Reply-To: References: Message-ID: <1aBhhGesOoFLFvuoyD0CB05WTEzG7oJXZ5pK10hQuLk=.976c45ba-44a4-463f-afeb-e47e0fe7536b@github.com> On Thu, 23 Jan 2025 11:40:11 GMT, Jan Lahoda wrote: > The `FailOverDirectExecutionControlTest` test looks-up/creates a `Logger`, configures it, but it is not holding it while the test is running. As a consequence, the `Logger` may be GCed, loosing the configuration, and consequently failing the test. > > The proposal in this PR is to hold the configured `Logger` instance for the duration of the test. Makes sense. LogManager keeps weak references to loggers, which is definitely not suitable for this test. We need our own explicit reference instead. ------------- Marked as reviewed by liach (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/23265#pullrequestreview-2593305274 From jlahoda at openjdk.org Wed Feb 5 06:47:19 2025 From: jlahoda at openjdk.org (Jan Lahoda) Date: Wed, 5 Feb 2025 06:47:19 GMT Subject: Integrated: 8347629: Test FailOverDirectExecutionControlTest.java fails with -Xcomp In-Reply-To: References: Message-ID: On Thu, 23 Jan 2025 11:40:11 GMT, Jan Lahoda wrote: > The `FailOverDirectExecutionControlTest` test looks-up/creates a `Logger`, configures it, but it is not holding it while the test is running. As a consequence, the `Logger` may be GCed, loosing the configuration, and consequently failing the test. > > The proposal in this PR is to hold the configured `Logger` instance for the duration of the test. This pull request has now been integrated. Changeset: 09269497 Author: Jan Lahoda URL: https://git.openjdk.org/jdk/commit/09269497a27c732ce4644d0bb95e0380162398c9 Stats: 4 lines in 1 file changed: 2 ins; 1 del; 1 mod 8347629: Test FailOverDirectExecutionControlTest.java fails with -Xcomp Reviewed-by: liach ------------- PR: https://git.openjdk.org/jdk/pull/23265 From dholmes at openjdk.org Thu Feb 6 01:52:57 2025 From: dholmes at openjdk.org (David Holmes) Date: Thu, 6 Feb 2025 01:52:57 GMT Subject: RFR: 8349511: [BACKOUT] Framework for tracing makefile inclusion and parsing Message-ID: <2bf6g3iLVTSpqlp0ka4LeAovJRyPvdibwFZsONUGPI4=.3d01a784-5e93-4c78-87c6-a31c948a81c0@github.com> This reverts commit 61465883b465a184e31e7a03e2603d29ab4815a4. JDK-8348190: Framework for tracing makefile inclusion and parsing The above issue caused problems in the Oracle closed builds and so needs to be backed out until that is addressed. Thanks. ------------- Commit messages: - Revert "8348190: Framework for tracing makefile inclusion and parsing" Changes: https://git.openjdk.org/jdk/pull/23481/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=23481&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8349511 Stats: 2717 lines in 273 files changed: 501 ins; 1663 del; 553 mod Patch: https://git.openjdk.org/jdk/pull/23481.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/23481/head:pull/23481 PR: https://git.openjdk.org/jdk/pull/23481 From darcy at openjdk.org Thu Feb 6 02:04:15 2025 From: darcy at openjdk.org (Joe Darcy) Date: Thu, 6 Feb 2025 02:04:15 GMT Subject: RFR: 8349511: [BACKOUT] Framework for tracing makefile inclusion and parsing In-Reply-To: <2bf6g3iLVTSpqlp0ka4LeAovJRyPvdibwFZsONUGPI4=.3d01a784-5e93-4c78-87c6-a31c948a81c0@github.com> References: <2bf6g3iLVTSpqlp0ka4LeAovJRyPvdibwFZsONUGPI4=.3d01a784-5e93-4c78-87c6-a31c948a81c0@github.com> Message-ID: On Thu, 6 Feb 2025 01:32:51 GMT, David Holmes wrote: > This reverts commit 61465883b465a184e31e7a03e2603d29ab4815a4. > > JDK-8348190: Framework for tracing makefile inclusion and parsing > > The above issue caused problems in the Oracle closed builds and so needs to be backed out until that is addressed. > > Thanks. Approving clean backout. ------------- Marked as reviewed by darcy (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/23481#pullrequestreview-2597463613 From dholmes at openjdk.org Thu Feb 6 02:44:08 2025 From: dholmes at openjdk.org (David Holmes) Date: Thu, 6 Feb 2025 02:44:08 GMT Subject: RFR: 8349511: [BACKOUT] Framework for tracing makefile inclusion and parsing In-Reply-To: References: <2bf6g3iLVTSpqlp0ka4LeAovJRyPvdibwFZsONUGPI4=.3d01a784-5e93-4c78-87c6-a31c948a81c0@github.com> Message-ID: On Thu, 6 Feb 2025 02:01:47 GMT, Joe Darcy wrote: >> This reverts commit 61465883b465a184e31e7a03e2603d29ab4815a4. >> >> JDK-8348190: Framework for tracing makefile inclusion and parsing >> >> The above issue caused problems in the Oracle closed builds and so needs to be backed out until that is addressed. >> >> Thanks. > > Approving clean backout. Thanks @jddarcy ! ------------- PR Comment: https://git.openjdk.org/jdk/pull/23481#issuecomment-2638687813 From mikael at openjdk.org Thu Feb 6 02:54:17 2025 From: mikael at openjdk.org (Mikael Vidstedt) Date: Thu, 6 Feb 2025 02:54:17 GMT Subject: RFR: 8349511: [BACKOUT] Framework for tracing makefile inclusion and parsing In-Reply-To: <2bf6g3iLVTSpqlp0ka4LeAovJRyPvdibwFZsONUGPI4=.3d01a784-5e93-4c78-87c6-a31c948a81c0@github.com> References: <2bf6g3iLVTSpqlp0ka4LeAovJRyPvdibwFZsONUGPI4=.3d01a784-5e93-4c78-87c6-a31c948a81c0@github.com> Message-ID: On Thu, 6 Feb 2025 01:32:51 GMT, David Holmes wrote: > This reverts commit 61465883b465a184e31e7a03e2603d29ab4815a4. > > JDK-8348190: Framework for tracing makefile inclusion and parsing > > The above issue caused problems in the Oracle closed builds and so needs to be backed out until that is addressed. > > Thanks. Marked as reviewed by mikael (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk/pull/23481#pullrequestreview-2597531112 From dholmes at openjdk.org Thu Feb 6 02:54:18 2025 From: dholmes at openjdk.org (David Holmes) Date: Thu, 6 Feb 2025 02:54:18 GMT Subject: RFR: 8349511: [BACKOUT] Framework for tracing makefile inclusion and parsing In-Reply-To: References: <2bf6g3iLVTSpqlp0ka4LeAovJRyPvdibwFZsONUGPI4=.3d01a784-5e93-4c78-87c6-a31c948a81c0@github.com> Message-ID: On Thu, 6 Feb 2025 02:48:21 GMT, Mikael Vidstedt wrote: >> This reverts commit 61465883b465a184e31e7a03e2603d29ab4815a4. >> >> JDK-8348190: Framework for tracing makefile inclusion and parsing >> >> The above issue caused problems in the Oracle closed builds and so needs to be backed out until that is addressed. >> >> Thanks. > > Marked as reviewed by mikael (Reviewer). Thanks @vidmik ! ------------- PR Comment: https://git.openjdk.org/jdk/pull/23481#issuecomment-2638701374 From dholmes at openjdk.org Thu Feb 6 02:54:18 2025 From: dholmes at openjdk.org (David Holmes) Date: Thu, 6 Feb 2025 02:54:18 GMT Subject: Integrated: 8349511: [BACKOUT] Framework for tracing makefile inclusion and parsing In-Reply-To: <2bf6g3iLVTSpqlp0ka4LeAovJRyPvdibwFZsONUGPI4=.3d01a784-5e93-4c78-87c6-a31c948a81c0@github.com> References: <2bf6g3iLVTSpqlp0ka4LeAovJRyPvdibwFZsONUGPI4=.3d01a784-5e93-4c78-87c6-a31c948a81c0@github.com> Message-ID: On Thu, 6 Feb 2025 01:32:51 GMT, David Holmes wrote: > This reverts commit 61465883b465a184e31e7a03e2603d29ab4815a4. > > JDK-8348190: Framework for tracing makefile inclusion and parsing > > The above issue caused problems in the Oracle closed builds and so needs to be backed out until that is addressed. > > Thanks. This pull request has now been integrated. Changeset: 64bd8d25 Author: David Holmes URL: https://git.openjdk.org/jdk/commit/64bd8d2592d26e02a7f2f96caa47cba5e158aaa2 Stats: 2717 lines in 273 files changed: 501 ins; 1663 del; 553 mod 8349511: [BACKOUT] Framework for tracing makefile inclusion and parsing Reviewed-by: darcy, mikael ------------- PR: https://git.openjdk.org/jdk/pull/23481 From duke at openjdk.org Fri Feb 14 17:50:19 2025 From: duke at openjdk.org (duke) Date: Fri, 14 Feb 2025 17:50:19 GMT Subject: Withdrawn: 8285150: Improve tab completion for annotations In-Reply-To: References: Message-ID: On Fri, 20 Dec 2024 06:24:13 GMT, Jan Lahoda wrote: > When using types code like: > > @Deprecated( > > > and presses ``, there should be a sensible completion, but currently there is nothing. This PR proposes to add code completion for annotation attributes. This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk/pull/22840 From duke at openjdk.org Fri Feb 14 23:23:15 2025 From: duke at openjdk.org (duke) Date: Fri, 14 Feb 2025 23:23:15 GMT Subject: Withdrawn: 8341833: incomplete snippet from loaded files from command line is ignored In-Reply-To: References: Message-ID: On Fri, 20 Dec 2024 17:32:33 GMT, Jan Lahoda wrote: > If JShell is run with a parameter that is a file, and the file ends with an incomplete snippet, the incomplete snippet is ignored. > > For example: > > t.jsh: > class { > > > jshell /tmp/t.jsh > | Welcome to JShell -- Version 21.0.5 > | For an introduction type: /help intro > > jshell> > > > This PR proposes to produce an explicit error in this case: > > $ jshell /tmp/t.jsh > Building target 'default (exploded-image)' in configuration 'linux-x86_64-server-release' > Finished building target 'default (exploded-image)' in configuration 'linux-x86_64-server-release' > Incomplete input: class { > | Welcome to JShell -- Version 25-internal > | For an introduction type: /help intro > > jshell> This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk/pull/22850 From alanb at openjdk.org Mon Feb 17 15:26:14 2025 From: alanb at openjdk.org (Alan Bateman) Date: Mon, 17 Feb 2025 15:26:14 GMT Subject: RFR: 8347123: Add missing @serial tags to other modules [v2] In-Reply-To: References: Message-ID: On Fri, 24 Jan 2025 10:58:24 GMT, Hannes Walln?fer wrote: >> Please review a doc-only change to mostly add missing `@serial` javadoc tags. This is a sub-task of [JDK-8286931] to allow us to re-enable the javadoc `-serialwarn` option in the JDK doc build, which has been disabled since JDK 19. >> >> [JDK-8286931]: https://bugs.openjdk.org/browse/JDK-8286931 >> >> For private and package-private serialized fields that already have a doc comment, the main description is converted to a block tag by prepending `@serial` since these fields do not require a main description. For protected and public serialized fields that require a main description, an empty `@serial` block tag is appended to the doc comment instead. The effect is the same, as the main description is used in `serial-form.html` if the `@serial` tag is missing or empty. For those fields that do not have a doc comment, a doc comment with an empty `@serial` tag is added. >> >> Apart from missing `@serial` tags, this PR also adds a `@serialData` tag to `java.awt.datatransfer.DataFlavor.writeExternal(ObjectOutput)` that the javadoc `-serialwarn` option complains about. This is the only change in this PR that adds documentation text and causes a change in the generated documentation. > > Hannes Walln?fer has updated the pull request incrementally with one additional commit since the last revision: > > Update @serialData text to CSR-approved version I think this is oky, the CSR for the change writeExternal has already been reviewed. ------------- Marked as reviewed by alanb (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/22980#pullrequestreview-2621362315 From hannesw at openjdk.org Mon Feb 17 15:34:16 2025 From: hannesw at openjdk.org (Hannes =?UTF-8?B?V2FsbG7DtmZlcg==?=) Date: Mon, 17 Feb 2025 15:34:16 GMT Subject: Integrated: 8347123: Add missing @serial tags to other modules In-Reply-To: References: Message-ID: On Wed, 8 Jan 2025 20:13:50 GMT, Hannes Walln?fer wrote: > Please review a doc-only change to mostly add missing `@serial` javadoc tags. This is a sub-task of [JDK-8286931] to allow us to re-enable the javadoc `-serialwarn` option in the JDK doc build, which has been disabled since JDK 19. > > [JDK-8286931]: https://bugs.openjdk.org/browse/JDK-8286931 > > For private and package-private serialized fields that already have a doc comment, the main description is converted to a block tag by prepending `@serial` since these fields do not require a main description. For protected and public serialized fields that require a main description, an empty `@serial` block tag is appended to the doc comment instead. The effect is the same, as the main description is used in `serial-form.html` if the `@serial` tag is missing or empty. For those fields that do not have a doc comment, a doc comment with an empty `@serial` tag is added. > > Apart from missing `@serial` tags, this PR also adds a `@serialData` tag to `java.awt.datatransfer.DataFlavor.writeExternal(ObjectOutput)` that the javadoc `-serialwarn` option complains about. This is the only change in this PR that adds documentation text and causes a change in the generated documentation. This pull request has now been integrated. Changeset: 3f0c1370 Author: Hannes Walln?fer URL: https://git.openjdk.org/jdk/commit/3f0c1370269db978072814c2170fc3987efade85 Stats: 104 lines in 39 files changed: 45 ins; 0 del; 59 mod 8347123: Add missing @serial tags to other modules Reviewed-by: prr, nbenalla, alanb ------------- PR: https://git.openjdk.org/jdk/pull/22980 From acobbs at openjdk.org Wed Feb 26 19:08:09 2025 From: acobbs at openjdk.org (Archie Cobbs) Date: Wed, 26 Feb 2025 19:08:09 GMT Subject: RFR: 8299934: LocalExecutionControl replaces default uncaught exception handler In-Reply-To: References: Message-ID: On Fri, 10 Mar 2023 19:48:42 GMT, Jan Lahoda wrote: > The JShell's `LocalExecutionControl` set the global default uncaught exception handler, causing problems to external code that might rely on it (even if only for logging/debugging purposes). > > The proposal here is to do what the bug is suggesting, and only handling the exception inside the `ThreadGroup` that JShell creates. The patch does not strive to do further changes to how the exception handling is done. Any reason not to reopen this PR? It seems like a good thing to fix. ------------- PR Comment: https://git.openjdk.org/jdk/pull/12982#issuecomment-2685948161 From acobbs at openjdk.org Wed Feb 26 19:48:30 2025 From: acobbs at openjdk.org (Archie Cobbs) Date: Wed, 26 Feb 2025 19:48:30 GMT Subject: RFR: 8350808: Small typos in JShell method SnippetEvent.toString() Message-ID: This PR which fixes three small typos in the method `SnippetEvent.toString()`. ------------- Commit messages: - Fix typos in the JShell method SnippetEvent.toString(). Changes: https://git.openjdk.org/jdk/pull/23809/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=23809&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8350808 Stats: 67 lines in 2 files changed: 63 ins; 0 del; 4 mod Patch: https://git.openjdk.org/jdk/pull/23809.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/23809/head:pull/23809 PR: https://git.openjdk.org/jdk/pull/23809