RFR: 8347629: Test FailOverDirectExecutionControlTest.java fails with -Xcomp
Chen Liang
liach at openjdk.org
Tue Feb 4 15:55:11 UTC 2025
On Thu, 23 Jan 2025 11:40:11 GMT, Jan Lahoda <jlahoda at openjdk.org> wrote:
> The `FailOverDirectExecutionControlTest` test looks-up/creates a `Logger`, configures it, but it is not holding it while the test is running. As a consequence, the `Logger` may be GCed, loosing the configuration, and consequently failing the test.
>
> The proposal in this PR is to hold the configured `Logger` instance for the duration of the test.
Makes sense. LogManager keeps weak references to loggers, which is definitely not suitable for this test. We need our own explicit reference instead.
-------------
Marked as reviewed by liach (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/23265#pullrequestreview-2593305274
More information about the kulla-dev
mailing list