RFR: 8177650: JShell tool: packages in classpath don't appear in completions [v2]
Jan Lahoda
jlahoda at openjdk.org
Mon Jul 7 13:05:28 UTC 2025
> JShell provides the code completion feature, where it suggests possible follow ups for a given snippet prefix. To allow completion for packages, JShell uses a background task to go through known classes and create an index for them.
>
> There are two problems with this background task:
> - the classpath is read from the JShell's FileManager, but the FileManager may not be configured with the compile options yet, so the classpath may not be filled yet,
> - the module path is not included in the list of paths to paths to search
>
> This PR proposes to:
> - use FileManager configured by passing the compile options through javac
> - include the module path in the search path
Jan Lahoda has updated the pull request incrementally with one additional commit since the last revision:
Avoiding problems with locked files on Windows.
-------------
Changes:
- all: https://git.openjdk.org/jdk/pull/26137/files
- new: https://git.openjdk.org/jdk/pull/26137/files/ec2dcb89..54eed125
Webrevs:
- full: https://webrevs.openjdk.org/?repo=jdk&pr=26137&range=01
- incr: https://webrevs.openjdk.org/?repo=jdk&pr=26137&range=00-01
Stats: 10 lines in 2 files changed: 7 ins; 2 del; 1 mod
Patch: https://git.openjdk.org/jdk/pull/26137.diff
Fetch: git fetch https://git.openjdk.org/jdk.git pull/26137/head:pull/26137
PR: https://git.openjdk.org/jdk/pull/26137
More information about the kulla-dev
mailing list