RFR: 8348611: Eliminate DeferredLintHandler and emit warnings after attribution [v3]

[Archie Cobbs]

On Mon, 28 Jul 2025 16:53:05 GMT, Maurizio Cimadamore <mcimadamore at openjdk.org> wrote:

>> Archie Cobbs has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 89 commits:
>> 
>>  - Add DEFAULT_ENABLED flags to fix some mandatory warnings.
>>  - Merge branch 'master' into JDK-8348611 to fix conflicts.
>>  - Merge branch 'master' into JDK-8348611 to fix conflicts.
>>  - Merge branch 'master' into JDK-8348611 to fix conflicts.
>>  - Merge branch 'MandatoryWarningCleanup' into JDK-8348611
>>  - Address review suggestions.
>>  - Remove assumptions about mandatoryness from the MandatoryWarningAggregator.
>>  - Merge branch 'MandatoryWarningCleanup' into JDK-8348611
>>  - Merge branch 'master' into MandatoryWarningCleanup
>>  - Merge branch 'MandatoryWarningCleanup' into JDK-8348611
>>  - ... and 79 more: https://git.openjdk.org/jdk/compare/cab51596...91202f7b
>
> src/jdk.compiler/share/classes/com/sun/tools/javac/code/LintMapper.java line 283:
> 
>> 281:      * nodes representing the top-level declarations in the file, and so on.
>> 282:      */
>> 283:     private static class DeclNode extends Span {
> 
> This also seems to suggest that some of the spans computed after parsing are later "promoted" to decl nodes. But the code doesn't work like this, instead it tracks spans and decls separately into the same FileInfo data structure, which I find a bit odd.

Should be improved in f65e1950467. Thanks.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/24584#discussion_r2237935618