From vyazici at openjdk.org  Mon Jun  2 11:25:30 2025
From: vyazici at openjdk.org (Volkan Yazici)
Date: Mon, 2 Jun 2025 11:25:30 GMT
Subject: RFR: 8357996: Use "stdin.encoding" for reading System.in with
 InputStreamReader/Scanner [build/tools] [v2]
In-Reply-To: <uYEjhyAWjyat_rQLDhluHk94UFnqQroygDPyKUC5ixw=.dc57140a-6176-4a4e-b4d2-ee00419a24d6@github.com>
References: <uYEjhyAWjyat_rQLDhluHk94UFnqQroygDPyKUC5ixw=.dc57140a-6176-4a4e-b4d2-ee00419a24d6@github.com>
Message-ID: <1QWJ_Ube42oc8fNmEnCWJb3J5HNR2aaDhbxW2NwT6MA=.4da44e83-fe48-43a8-8537-925135166c04@github.com>

> Passes the `Charset` read from the `stdin.encoding` system property while creating `InputStreamReader` or `Scanner` instances for `System.in`.
> 
> `stdin.encoding` is a recently added property for Java 25 in [JDK-8350703](https://bugs.openjdk.org/browse/JDK-8350703). Employing it throughout the entire code base is addressed by the parent ticket [JDK-8356893](https://bugs.openjdk.org/browse/JDK-8356893). JDK-8357996 this PR is addressing is a sub-task of JDK-8356893 and is concerned with only areas related to build and tools.

Volkan Yazici has updated the pull request incrementally with one additional commit since the last revision:

  Provide fallback for `stdin.encoding` in `ExternalEditor`

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/25541/files
  - new: https://git.openjdk.org/jdk/pull/25541/files/329180f5..c0dfa806

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=25541&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=25541&range=00-01

  Stats: 3 lines in 1 file changed: 2 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/jdk/pull/25541.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/25541/head:pull/25541

PR: https://git.openjdk.org/jdk/pull/25541

From vyazici at openjdk.org  Mon Jun  2 11:25:31 2025
From: vyazici at openjdk.org (Volkan Yazici)
Date: Mon, 2 Jun 2025 11:25:31 GMT
Subject: RFR: 8357996: Use "stdin.encoding" for reading System.in with
 InputStreamReader/Scanner [build/tools] [v2]
In-Reply-To: <1QWJ_Ube42oc8fNmEnCWJb3J5HNR2aaDhbxW2NwT6MA=.4da44e83-fe48-43a8-8537-925135166c04@github.com>
References: <uYEjhyAWjyat_rQLDhluHk94UFnqQroygDPyKUC5ixw=.dc57140a-6176-4a4e-b4d2-ee00419a24d6@github.com>
 <1QWJ_Ube42oc8fNmEnCWJb3J5HNR2aaDhbxW2NwT6MA=.4da44e83-fe48-43a8-8537-925135166c04@github.com>
Message-ID: <MFFrjyTzk_ej3pJCwlYbpbfEta6CSHn4X2mMdiLawYs=.dbf3d8d3-b485-4e4c-9ceb-4e6a7c23f10c@github.com>

On Mon, 2 Jun 2025 11:22:21 GMT, Volkan Yazici <vyazici at openjdk.org> wrote:

>> Passes the `Charset` read from the `stdin.encoding` system property while creating `InputStreamReader` or `Scanner` instances for `System.in`.
>> 
>> `stdin.encoding` is a recently added property for Java 25 in [JDK-8350703](https://bugs.openjdk.org/browse/JDK-8350703). Employing it throughout the entire code base is addressed by the parent ticket [JDK-8356893](https://bugs.openjdk.org/browse/JDK-8356893). JDK-8357996 this PR is addressing is a sub-task of JDK-8356893 and is concerned with only areas related to build and tools.
>
> Volkan Yazici has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Provide fallback for `stdin.encoding` in `ExternalEditor`

src/utils/src/build/tools/commentchecker/CommentChecker.java line 197:

> 195:             try {
> 196:                 BufferedReader br =
> 197:                     new BufferedReader(new InputStreamReader(System.in, System.getProperty("stdin.encoding")));

Not providing a `Charset` fallback ? `CommentChecker` build tool should better fail if an invalid `stdin.encoding` is configured.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/25541#discussion_r2120845904

From davidalayachew at gmail.com  Tue Jun  3 00:52:54 2025
From: davidalayachew at gmail.com (David Alayachew)
Date: Mon, 2 Jun 2025 20:52:54 -0400
Subject: jshell has unreadable javadoc on Git Bash
Message-ID: <CAA9v-_OUknzCp0KsytMfT51jAJYswWOPDT2-N_W_N12gTYuMDg@mail.gmail.com>

Hello @kulla-dev at openjdk.org <kulla-dev at openjdk.org> ,

I was using jshell to write some stream code today, and I was doing this in
Git Bash on Windows 10.

I did list.stream(), then used Shift+Enter to create a new line for each
method on my stream. Typical builder-style code formatting.

Then, I pressed Tab in order to see javadoc for one of the methods, and the
resulting javadoc was basically illegible. It was a mix of the multi-line
stream and the javadoc, jumbled together.

I think this is a bug? Can something be done to resolve this? Let me know
if more information is needed.

Thank you for your time and consideration.
David Alayachew
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.org/pipermail/kulla-dev/attachments/20250602/64e68a2f/attachment.htm>

From davidalayachew at gmail.com  Tue Jun  3 00:57:43 2025
From: davidalayachew at gmail.com (David Alayachew)
Date: Mon, 2 Jun 2025 20:57:43 -0400
Subject: jshell has unreadable javadoc on Git Bash
In-Reply-To: <CAA9v-_OUknzCp0KsytMfT51jAJYswWOPDT2-N_W_N12gTYuMDg@mail.gmail.com>
References: <CAA9v-_OUknzCp0KsytMfT51jAJYswWOPDT2-N_W_N12gTYuMDg@mail.gmail.com>
Message-ID: <CAA9v-_OABhfYKb2j+CQAbhFUXgUx=W0j_pN+U9f7=1sEnQ3pVA@mail.gmail.com>

Side note -- the same problem occurs in Commandline too for Windows 10. The
only difference is that I can't use Shift+Enter to create the new lines.
Instead, I did a .map(somePath -> {, and then pressed enter. The opening
curly brace then allowed my enter to create a new line. After making a few
new lines, then trying to press tab on a half-typed method, I got the same,
garbled text.


And to be clear, they are garbled/interspersed, even on the same line.

On Mon, Jun 2, 2025, 8:52?PM David Alayachew <davidalayachew at gmail.com>
wrote:

> Hello @kulla-dev at openjdk.org <kulla-dev at openjdk.org> ,
>
> I was using jshell to write some stream code today, and I was doing this
> in Git Bash on Windows 10.
>
> I did list.stream(), then used Shift+Enter to create a new line for each
> method on my stream. Typical builder-style code formatting.
>
> Then, I pressed Tab in order to see javadoc for one of the methods, and
> the resulting javadoc was basically illegible. It was a mix of the
> multi-line stream and the javadoc, jumbled together.
>
> I think this is a bug? Can something be done to resolve this? Let me know
> if more information is needed.
>
> Thank you for your time and consideration.
> David Alayachew
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.org/pipermail/kulla-dev/attachments/20250602/6ddf711d/attachment-0001.htm>

From nbenalla at openjdk.org  Tue Jun  3 11:19:34 2025
From: nbenalla at openjdk.org (Nizar Benalla)
Date: Tue, 3 Jun 2025 11:19:34 GMT
Subject: RFR: 8346884: Add since checker test to jdk.editpad
Message-ID: <eqA9zD_EnXUJr7Q_xq7OZbBzAxViuUHyzy0Tw6LtZ8U=.6868ebd9-4afa-4a03-8c2d-7addef9a2ddf@github.com>

Please review this patch to add a new test to check `@since` tags in the `jdk.editpad` module.

TIA

-------------

Commit messages:
 - add new `@since` test

Changes: https://git.openjdk.org/jdk/pull/25613/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=25613&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8346884
  Stats: 30 lines in 1 file changed: 30 ins; 0 del; 0 mod
  Patch: https://git.openjdk.org/jdk/pull/25613.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/25613/head:pull/25613

PR: https://git.openjdk.org/jdk/pull/25613

From nbenalla at openjdk.org  Tue Jun  3 11:19:34 2025
From: nbenalla at openjdk.org (Nizar Benalla)
Date: Tue, 3 Jun 2025 11:19:34 GMT
Subject: RFR: 8346884: Add since checker test to jdk.editpad
In-Reply-To: <eqA9zD_EnXUJr7Q_xq7OZbBzAxViuUHyzy0Tw6LtZ8U=.6868ebd9-4afa-4a03-8c2d-7addef9a2ddf@github.com>
References: <eqA9zD_EnXUJr7Q_xq7OZbBzAxViuUHyzy0Tw6LtZ8U=.6868ebd9-4afa-4a03-8c2d-7addef9a2ddf@github.com>
Message-ID: <CKteKl44uoBG40c95jLiAemwvEUmI-3X9nrJOfz8Q4s=.a0e6aefa-ef23-4746-9174-5eeb0ab25b99@github.com>

On Tue, 3 Jun 2025 10:09:44 GMT, Nizar Benalla <nbenalla at openjdk.org> wrote:

> Please review this patch to add a new test to check `@since` tags in the `jdk.editpad` module.
> 
> TIA

I realize there are no classfiles in `jdk.editpad` but the test can also check the `@since` information in the `module-info.java` file.

The goal is to have an `@since` test per module.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/25613#issuecomment-2934750409

From ihse at openjdk.org  Tue Jun  3 19:20:20 2025
From: ihse at openjdk.org (Magnus Ihse Bursie)
Date: Tue, 3 Jun 2025 19:20:20 GMT
Subject: RFR: 8357996: Use "stdin.encoding" for reading System.in with
 InputStreamReader/Scanner [build/tools] [v2]
In-Reply-To: <1QWJ_Ube42oc8fNmEnCWJb3J5HNR2aaDhbxW2NwT6MA=.4da44e83-fe48-43a8-8537-925135166c04@github.com>
References: <uYEjhyAWjyat_rQLDhluHk94UFnqQroygDPyKUC5ixw=.dc57140a-6176-4a4e-b4d2-ee00419a24d6@github.com>
 <1QWJ_Ube42oc8fNmEnCWJb3J5HNR2aaDhbxW2NwT6MA=.4da44e83-fe48-43a8-8537-925135166c04@github.com>
Message-ID: <VE6-ysfybzJbgR-ScS5S3G3Z_k7_4nfolGr8Yp_aQDM=.e4064ea2-50b8-4e83-b3fc-b68e1faa58d1@github.com>

On Mon, 2 Jun 2025 11:25:30 GMT, Volkan Yazici <vyazici at openjdk.org> wrote:

>> Passes the `Charset` read from the `stdin.encoding` system property while creating `InputStreamReader` or `Scanner` instances for `System.in`.
>> 
>> `stdin.encoding` is a recently added property for Java 25 in [JDK-8350703](https://bugs.openjdk.org/browse/JDK-8350703). Employing it throughout the entire code base is addressed by the parent ticket [JDK-8356893](https://bugs.openjdk.org/browse/JDK-8356893). JDK-8357996 this PR is addressing is a sub-task of JDK-8356893 and is concerned with only areas related to build and tools.
>
> Volkan Yazici has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Provide fallback for `stdin.encoding` in `ExternalEditor`

Maybe you should update the JBS title?

-------------

PR Comment: https://git.openjdk.org/jdk/pull/25541#issuecomment-2936822614

From vyazici at openjdk.org  Tue Jun  3 19:39:22 2025
From: vyazici at openjdk.org (Volkan Yazici)
Date: Tue, 3 Jun 2025 19:39:22 GMT
Subject: RFR: 8357996: Use "stdin.encoding" for reading System.in with
 InputStreamReader/Scanner [tools] [v2]
In-Reply-To: <VE6-ysfybzJbgR-ScS5S3G3Z_k7_4nfolGr8Yp_aQDM=.e4064ea2-50b8-4e83-b3fc-b68e1faa58d1@github.com>
References: <uYEjhyAWjyat_rQLDhluHk94UFnqQroygDPyKUC5ixw=.dc57140a-6176-4a4e-b4d2-ee00419a24d6@github.com>
 <1QWJ_Ube42oc8fNmEnCWJb3J5HNR2aaDhbxW2NwT6MA=.4da44e83-fe48-43a8-8537-925135166c04@github.com>
 <VE6-ysfybzJbgR-ScS5S3G3Z_k7_4nfolGr8Yp_aQDM=.e4064ea2-50b8-4e83-b3fc-b68e1faa58d1@github.com>
Message-ID: <qcwzQNhPR1XDKFgcKxTgfR2kmmkxhieo9KiLitxn_F8=.f4e9cab1-f58c-489f-b12b-041ea4e2e5a4@github.com>

On Tue, 3 Jun 2025 19:17:57 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:

> Maybe you should update the JBS title?

@magicus, removed the mention of `build` from

- JBS title
- JBS description
- PR title
- PR description

-------------

PR Comment: https://git.openjdk.org/jdk/pull/25541#issuecomment-2936882813