RFR: 8356165: System.in in jshell replace supplementary characters with ?? [v3]

[Tatsunori Uchino]

On Mon, 19 May 2025 13:24:15 GMT, Adam Sotona <asotona at openjdk.org> wrote:

>> FWIW, we could do this:
>> https://github.com/lahodaj/jdk/commit/6a07648829ee8df263cf3fc1c55055fe45d4eb17
>
> Readability of the code is my preference unless the performance is absolutely critical (not this case).

> https://github.com/lahodaj/jdk/commit/6a07648829ee8df263cf3fc1c55055fe45d4eb17

Better than my suggestion.

The current code using StringBuilder is not bad because the act to pass a very long string to JShell seems to be something like shooting ourselves in the foot.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/25079#discussion_r2095867746