RFR: 8356165: System.in in jshell replace supplementary characters with ?? [v3]
Tatsunori Uchino
duke at openjdk.org
Tue May 20 03:47:52 UTC 2025
On Mon, 19 May 2025 14:38:21 GMT, Tatsunori Uchino <duke at openjdk.org> wrote:
>> Readability of the code is my preference unless the performance is absolutely critical (not this case).
>
>> https://github.com/lahodaj/jdk/commit/6a07648829ee8df263cf3fc1c55055fe45d4eb17
>
> Better than my suggestion.
>
> The current code using StringBuilder is not bad because the act to pass a very long string to JShell seems to be something like shooting ourselves in the foot.
You can /integrate the current code with StringBuilder.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/25079#discussion_r2096814538
More information about the kulla-dev
mailing list