<div dir="ltr"><div dir="ltr">On Tue, Aug 15, 2023 at 10:10 AM Jan Lahoda <<a href="mailto:jan.lahoda@oracle.com">jan.lahoda@oracle.com</a>> wrote:</div><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><u></u>
<div>
<p>On 15. 08. 23 16:41, Archie Cobbs wrote:</p>
<blockquote type="cite">
<div dir="ltr">On Tue, Aug 15, 2023 at 8:12 AM Jan Lahoda <<a href="mailto:jan.lahoda@oracle.com" target="_blank">jan.lahoda@oracle.com</a>>
wrote:
<div class="gmail_quote">
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<div><br>
<blockquote type="cite">
<div dir="ltr">
<div>
<div><b>Question</b>: Shouldn't <span style="font-family:monospace">LoaderDelegate.addToClasspath()</span>
have been passed the <span style="font-family:monospace">--class-path</span>
flag at some point in the example above? <span style="font-family:arial,sans-serif">JShell's L</span><span style="font-family:monospace">ocalExecutionControl</span>
uses <span style="font-family:monospace">DefaultLoaderDelegate</span>,
which uses a class loader of type <span style="font-family:monospace">DefaultLoaderDelegate.</span><span style="font-family:monospace">RemoteClassLoader</span>.
This would have added <span style="font-family:monospace">classes</span> to
<span style="font-family:monospace">RemoteClassLoader</span><span style="font-family:arial,sans-serif">'s class
path.<br>
</span></div>
</div>
</div>
</blockquote>
<p>Possibly.<br>
</p>
</div>
</blockquote>
<div>Thanks for the mild endorsement :) If you don't object I
may file a bug for this.<br>
</div>
</div>
</div>
</blockquote>
<p>Sure, please do!</p></div></blockquote><div><br></div>I've filed a <a href="https://bugs.openjdk.org/browse/JDK-8314327">bug</a> and submitted a <a href="https://github.com/openjdk/jdk/pull/15311">PR</a> for this and a couple of related issues.<br></div><div class="gmail_quote"><br></div><div class="gmail_quote">Hopefully these are reasonable improvements - I'm of course interested in any feedback.<br></div><div class="gmail_quote"><br></div><div class="gmail_quote">Thanks,<br></div><div class="gmail_quote">-Archie<br></div><br><span class="gmail_signature_prefix">-- </span><br><div dir="ltr" class="gmail_signature">Archie L. Cobbs<br></div></div>