hg: lambda/collections/jdk: 2 new changesets

[Paul Benedict]

+1 Josh. I agree. Using target and source is more neutral.

On Wed, Feb 23, 2011 at 4:44 PM, Joshua Bloch <jjb at google.com> wrote:

> Brian,
>
> A minor nit:
>
> + private static<C extends Collection<T>, T> C filterTo(C from, C to,
> Predicate<? super T> predicate) {
>
> The T should be E, as it represents a collection *element *type. Similarly,
>
> + for (T t : from) {
>
> should be:
>
> + for (E e : from) {
>
> And while I'm being pedantic, I' not crazy about "from" as a variable name,
> it being a preposition and all. How about "source"?
>
> I realize that this is all just placeholder code, but I'm sending this
> anyway, in hopes that these stylistic nits get fixed when (and if) the code
> matures.
>
> Josh
>
>