Feedback on the implementation of StringJoiner

Stephen Colebourne scolebourne at joda.org
Tue Dec 11 00:54:37 PST 2012


On 10 December 2012 16:26, Henry Jen <henry.jen at oracle.com> wrote:
> I am doing some changes to adapt your feedbacks and trying to have minimum but enough APIs, latest proposed can be found at
>
> http://cr.openjdk.java.net/~henryjen/lambda/StringJoiner.1/webrev/

StringJoiner
Line 61 example - missing bracket )

First line of some method descriptions starts with lower case rather than upper.

Line 260 exception not listed in Javadoc

As a general rule, I would try very hard to return a String, not a
CharSequence. Accepting a CharSequence on input is OK, but returning
it gives very few guarantees to callers. Think Postels law.

Stephen


More information about the lambda-dev mailing list