RFR 2: JDK-8005263: Logging APIs takes Supplier<String> for message

Peter Levart peter.levart at gmail.com
Sat Dec 22 03:13:55 PST 2012


Hi Henry,

Plain and simple.

I just noticed a few spellings:

line 670, 696, 863: "Thus is it" -> "Thus it is"   - this one has 
already been written wrong in the original source, so it just multiplied 
by copy-paste
line 688, 743, 854: "Log a in-time" -> "Log an in-time"

Regards, Peter

On 12/22/2012 05:50 AM, Henry Jen wrote:
> Hi,
>
> Update patch with review feedback,
> - JavaDoc update for benefit and gotcha.
> - logEx/logpEx is not log/logp with Supplier<String> as last argument.
> As a matter of fact, all API with Supplier<String> takes it as last
> argument.
> - No more doLog(Level, Supplier<String>, Block<LogRecord>) helper for
> performance concerns.
>
> Specdiff and webrev can be found at following,
>
> http://cr.openjdk.java.net/~henryjen/ccc/8005263.1/specdiff/diff.html
> http://cr.openjdk.java.net/~henryjen/ccc/8005263.1/webrev/
>
> Cheers,
> Henry
>



More information about the lambda-dev mailing list