hg: lambda/lambda/jdk: Renamings and reorganizations, mostly away from .primitive package into desired target locations

Brian Goetz brian.goetz at oracle.com
Fri Dec 28 14:26:46 PST 2012


Thanks -- indeed a cut and paste bug.

On 12/28/2012 5:22 PM, Peter Levart wrote:
> Hi  Brian,
>
> I think that the non-null check in 3 primitive variants of Optional is
> unnecessary (copy-paste bug?). For example:
>
>      private final boolean isPresent;
>      private final long value;
>
>      private OptionalLong(long value) {
>          this.isPresent = true;
>          this.value = Objects.requireNonNull(value);
>      }
>
>
> Regards, Peter
>
> On 12/21/2012 11:47 PM, brian.goetz at oracle.com wrote:
>> Changeset: 34d14e377743
>> Author:    briangoetz
>> Date:      2012-12-21 17:47 -0500
>> URL:http://hg.openjdk.java.net/lambda/lambda/jdk/rev/34d14e377743
>>
>> Renamings and reorganizations, mostly away from .primitive package into desired target locations
>>
>> + src/share/classes/java/util/OptionalDouble.java
>> + src/share/classes/java/util/OptionalInt.java
>> + src/share/classes/java/util/OptionalLong.java
>> + src/share/classes/java/util/function/IntMultiFunction.java
>> + src/share/classes/java/util/stream/IntPipeline.java
>> + src/share/classes/java/util/stream/IntStream.java
>> ! src/share/classes/java/util/stream/ReferencePipeline.java
>> ! src/share/classes/java/util/stream/Stream.java
>> ! src/share/classes/java/util/stream/StreamShape.java
>> ! src/share/classes/java/util/stream/op/FindOp.java
>> - src/share/classes/java/util/stream/primitive/DoubleOptional.java
>> ! src/share/classes/java/util/stream/primitive/IntFoldOp.java
>> - src/share/classes/java/util/stream/primitive/IntMultiFunction.java
>> - src/share/classes/java/util/stream/primitive/IntMutableReducer.java
>> ! src/share/classes/java/util/stream/primitive/IntNodes.java
>> - src/share/classes/java/util/stream/primitive/IntOptional.java
>> - src/share/classes/java/util/stream/primitive/IntPipeline.java
>> ! src/share/classes/java/util/stream/primitive/IntSortedOp.java
>> - src/share/classes/java/util/stream/primitive/IntStream.java
>> - src/share/classes/java/util/stream/primitive/LongOptional.java
>> ! src/share/classes/java/util/stream/reduce/MutableReducer.java
>> ! test-ng/tests/org/openjdk/tests/java/util/stream/StreamLinkTest.java
>> ! test-ng/tests/org/openjdk/tests/java/util/stream/StreamReuseTest.java
>> ! test-ng/tests/org/openjdk/tests/java/util/stream/StreamTestScenario.java
>> ! test-ng/tests/org/openjdk/tests/java/util/stream/op/FindAnyOpTest.java
>> ! test-ng/tests/org/openjdk/tests/java/util/stream/op/FindFirstOpTest.java
>> ! test-ng/tests/org/openjdk/tests/java/util/stream/op/MatchOpTest.java
>> ! test-ng/tests/org/openjdk/tests/java/util/stream/primitive/IntMinMaxTest.java
>> ! test-ng/tests/org/openjdk/tests/java/util/stream/primitive/IntMultiMapOpTest.java
>> ! test-ng/tests/org/openjdk/tests/java/util/stream/primitive/IntReduceTest.java
>> ! test-ng/tests/org/openjdk/tests/java/util/stream/primitive/IntStreamSpliteratorTest.java
>> ! test-ng/tests/org/openjdk/tests/java/util/stream/primitive/IntStreamTestScenario.java
>>
>>
>


More information about the lambda-dev mailing list