hg: lambda/lambda/jdk: 2 new changesets

Brian Goetz brian.goetz at oracle.com
Mon Jun 25 07:29:24 PDT 2012


This is a reasonable place for such feedback.

The motivation for StringJoiner was twofold:
  - to address the long-standing RFE for String.join;
  - to provide an easy means of joining a stream of strings (e.g., names 
= people.map(Person::getName).into(new StringJoiner(", "))



On 6/25/2012 7:56 AM, Roel Spilker wrote:
> I have some feedback on the implementation of StringJoiner. Where and how
> can I give this feedback?
>
> Roel
>
> On Sat, Jun 23, 2012 at 3:10 AM,<stuart.marks at oracle.com>  wrote:
>
>> Changeset: 915296b3c16e
>> Author:    jgish
>> Date:      2012-06-20 18:40 -0400
>> URL:       http://hg.openjdk.java.net/lambda/lambda/jdk/rev/915296b3c16e
>>
>> 5015163: (str) String merge/join that is the inverse of String.split()
>> Summary: Convenience methods on String to access the
>> java.util.StringJoiner functionality
>> Reviewed-by: smarks, briangoetz
>>
>> ! src/share/classes/java/lang/AbstractStringBuilder.java
>> ! src/share/classes/java/lang/String.java
>> ! src/share/classes/java/lang/StringBuffer.java
>> ! src/share/classes/java/lang/StringBuilder.java
>> ! src/share/classes/java/util/StringJoiner.java
>> ! test-ng/tests/org/openjdk/tests/java/lang/StringTest.java
>> ! test-ng/tests/org/openjdk/tests/java/util/FillableStringTest.java
>> ! test-ng/tests/org/openjdk/tests/java/util/StringJoinerTest.java
>>
>> Changeset: 7af64c20ebe7
>> Author:    smarks
>> Date:      2012-06-22 18:12 -0700
>> URL:       http://hg.openjdk.java.net/lambda/lambda/jdk/rev/7af64c20ebe7
>>
>> merge
>>
>>
>>
>>
>


More information about the lambda-dev mailing list