hg: lambda/lambda/jdk: Pattern.splitAsStream.

Paul Sandoz paul.sandoz at oracle.com
Mon Apr 15 05:09:12 PDT 2013


Hi Peter,

On Apr 8, 2013, at 6:52 PM, Peter Levart <peter.levart at gmail.com> wrote:

> Hi Paul, Ben,
> 
> Is Pattern.MatcherIterator.accept() method some left-over? It doesn't seem to be used anywhere.
> 
> Also, isnt't (MatcherIterator.nextElement != null) <=> valueReady ? CharSequence.subSequence should never return null, so the code could be written without valueReady field.
> 

Thanks for pointing this out. Ben is looking into it.

Paul.

> Regards, Peter
> 
> On 04/08/2013 05:20 PM, paul.sandoz at oracle.com wrote:
>> Changeset: 526131346981
>> Author:    psandoz
>> Date:      2013-04-08 17:16 +0200
>> URL:       http://hg.openjdk.java.net/lambda/lambda/jdk/rev/526131346981
>> 
>> Pattern.splitAsStream.
>> Contributed-by: Ben Evans <benjamin.john.evans at gmail.com>
>> 
>> ! src/share/classes/java/util/regex/Pattern.java
>> + test-ng/tests/org/openjdk/tests/java/util/regex/PatternTest.java
>> 
>> 
> 



More information about the lambda-dev mailing list