RFR: 8001647: In-place methods on Collection/List

[Paul Sandoz]

On Apr 19, 2013, at 1:15 PM, Alan Bateman <Alan.Bateman at oracle.com> wrote:

> On 18/04/2013 19:49, Akhil Arora wrote:
>> Looks like the stars are aligning on getting on this into TL... the
>> refreshed webrev is -
>> 
>> http://cr.openjdk.java.net/~akhil/8001647.8/webrev/
>> 
> A minor comment on Collection.removeIf is "that satisifies the given predicate" might be better than "which matches the provided predicate". Also for completeness, you could say "RuntimeExceptions and Errors thrown by the predicate are propagated ...".
> 
> In List.replaceAll then @throws NullPointerException is listed twice, which is okay, but might be better to combine them. A typo in the second NPE description "if the an element".
> 
> In the implementation then the only thing that puzzled me is checking the modification count in legacy Vector, that seems unnecessary.
> 

The function value could structurally modify the Vector instance.

Paul.