RFR: 8023275: Wrapping collections should override default methods

Henry Jen henry.jen at oracle.com
Mon Aug 19 17:09:37 PDT 2013


On 08/19/2013 01:01 PM, Mike Duigou wrote:
> - @SuppressWarnings("unchecked") would appear to be in some of the cases.
> 

Added.

> - Replace:
> 
> @summary Unit tests for wrapping classes should delegate to default methods
> 
> with
> 
> @summary Ensure Collections wrapping classes provide non-default implementations
> 
> - ArrayList<Method> list -> List<Method> list
> 

Updated.

> - TestNG DataProviders can return Iterator<Object[]> which means you can return cases.iterator() rather than converting to an array.
> 
>

Thanks for the tip, testng javadoc doesn't mention it, but in document.
Since it's one time construction and not lazily, I didn't change it.

http://cr.openjdk.java.net/~henryjen/tl/8023275/1/webrev/

Cheers,
Henry


More information about the lambda-dev mailing list