RFR: 8016846: Pattern.splitAsStream tests required

[Henry Jen]

On 08/20/2013 12:58 PM, Jonathan Gibbons wrote:
> Henry,
> 
> I think you should sort out the issues you are having with jtreg.
> It is not yet clear to me that this is a jtreg issue as much as a test 
> or library issue.
> 

Thanks Jon for the help on jtreg issue, the test can be easily fixed by
adding an extra @build tag.

The new webrev is at
http://cr.openjdk.java.net/~henryjen/tl/8016846/1/webrev

Cheers,
Henry

> -- Jon
> 
> On 08/20/2013 12:48 PM, Henry Jen wrote:
>> On 07/24/2013 09:14 AM, Alan Bateman wrote:
>>> On 16/07/2013 12:05, Henry Jen wrote:
>>>> Hi,
>>>>
>>>> Please review the webrev at,
>>>>
>>>> http://cr.openjdk.java.net/~henryjen/tl/8016846/0/webrev/
>>>>
>>>> The test is mostly contributed by Ben Evans.
>>>>
>>>> Cheers,
>>>> Henry
>>>>
>>> It looks okay to me, just a concern that the tests for the regex API are
>>> normally in test/java/util/regex.
>>>
>> We are using stream test framework on this to verify all style of stream
>> works, with that we will need to have library on bootclasspath, and that
>> current prevent us from put it in test/java/util/regex because of jtreg
>> limitation.
>>
>> If no object, I'll push this at its current location. We can revisit
>> this when jtreg support is available.
>>
>> The other alternative is that we refactor the test to test only split,
>> and leave out the various style of stream checking. While we lose the
>> sanity check, but I don't think we lose much as the form of iterator
>> converted into stream and operated should have been covered in other
>> stream tests.
>>
>> Let me know if we think it's important enough to refactor the test.
>>
>> Cheers,
>> Henry
>>
> 
>