RFR: SpliteratorCollections test patch

Brian Goetz brian at briangoetz.com
Thu Jun 27 12:22:58 PDT 2013


Please review:

diff --git a/test/java/util/Spliterator/SpliteratorCollisions.java 
b/test/java/util/Spliterator/SpliteratorCollisions.java
--- a/test/java/util/Spliterator/SpliteratorCollisions.java
+++ b/test/java/util/Spliterator/SpliteratorCollisions.java
@@ -148,7 +148,6 @@
          List<Object[]> data = new ArrayList<>();
          for (int size : SIZES) {
              List<HashableInteger> exp = listIntRange(size, true);
-            exp.add(0, null);
              SpliteratorDataBuilder<HashableInteger> db = new 
SpliteratorDataBuilder<>(data, exp);

              // Maps

I think the exp.add() line is redundant (triggered by withNull=true in 
listIntRange call) and is causing UOEs because listIntRange returns an 
unmodifiable list.


More information about the lambda-dev mailing list