RFR JDK-8012645(3rd round): Stream methods on BitSet, Random, ThreadLocalRandom, ZipFile

[Henry Jen]

On 04/30/2013 12:32 AM, Alan Bateman wrote:
> On 30/04/2013 06:17, Henry Jen wrote:
>> Hi,
>>
>> Adapt feedback from the first round, updated webrev and specdiff can be
>> found at:
>>

>>
>> Summary of change,
>> 1. Javadoc change for ZipFile::stream
>> 2. A inner class implements Enumeration and Iterator for
>> ZipEntry/JarEntry, and the stream is now not order-significant.
>> 3. Added test case for close ZipFile and JarFile to throw
>> IllegalStateException.
>>
>> Cheers,
>> Henry
>>
> I see the inner classes are protected so they will leak into the API.
> The inner class is fine for ZipFile (assuming you change it to private
> or package-private). For JarFile then it might be simplest to just go
> back to what you had originally.

Please review

http://cr.openjdk.java.net/~henryjen/ccc/8012645.2/webrev
http://cr.openjdk.java.net/~henryjen/ccc/8012645.2/specdiff

- Fix the inner class.
- Add back the order for ZipFile.stream() and spec the order to be as
appears in the central directory of the zip file.

Cheers,
Henry