Review: demos for jdk8
Andrey Nazarov
andrey.x.nazarov at oracle.com
Mon Oct 14 08:46:46 PDT 2013
Thank you Paul,
I've fixed demo
http://cr.openjdk.java.net/~anazarov/try-with-resources/webrev.01
<http://cr.openjdk.java.net/%7Eanazarov/try-with-resources/webrev.01>
--Thanks, Andrey.
On 11.10.2013 19:04, Paul Benedict wrote:
> I think there may be a problem with Console::close(). Even though the
> Console instance will be disposed in a try-with-resources construct,
> that doesn't the reader and writer are guaranteed to close together.
> Currently, if the reader fails to close, the writer will be left
> dangling. What do you think of putting a try/catch in close() (and
> maybe suppressing one of them)?
>
>
> On Fri, Oct 11, 2013 at 9:56 AM, Andrey Nazarov
> <andrey.x.nazarov at oracle.com <mailto:andrey.x.nazarov at oracle.com>> wrote:
>
> Hi guys,
>
> Did you have a chance to review our jdk8 demos?
>
> http://cr.openjdk.java.net/~anazarov/try-with-resources/
> <http://cr.openjdk.java.net/%7Eanazarov/try-with-resources/>
> http://cr.openjdk.java.net/~anazarov/repeating-annotations/
> <http://cr.openjdk.java.net/%7Eanazarov/repeating-annotations/>
> http://cr.openjdk.java.net/~anazarov/jdk8-demo-bulkoperations/
> <http://cr.openjdk.java.net/%7Eanazarov/jdk8-demo-bulkoperations/>
> http://cr.openjdk.java.net/~anazarov/extension-methods/
> <http://cr.openjdk.java.net/%7Eanazarov/extension-methods/>
>
>
> -- Andrey.
>
> On 13.09.2013 5:49, Andrey Nazarov wrote:
> > I've fixed subject
> > ---
> > Hi guys,
> >
> > We want to push our demo code for try-with-resources feature
> > Could you please review this code?
> > http://cr.openjdk.java.net/~anazarov/try-with-resources/
> <http://cr.openjdk.java.net/%7Eanazarov/try-with-resources/>
> >
> >
> > --Andrey.
> >
>
>
>
>
>
> --
> Cheers,
> Paul
More information about the lambda-dev
mailing list