Comparator/Comparators API change proposal

[Henry Jen]

On 06/04/2013 05:10 PM, Michael Hixson wrote:
> On Mon, Jun 3, 2013 at 6:13 PM, Henry Jen <henry.jen at oracle.com> wrote:
>> On Jun 3, 2013, at 5:07 PM, Michael Hixson <michael.hixson at gmail.com> wrote:
>>
>>> 3. There are a couple of awkward-sounding parts in the docs, e.g. "Try
>>> to compare null with returned comparator will throw
>>> NullPointerException."  Do you want me (and/or others) to suggest
>>> concrete changes here, in this thread?
>>>
>>
>> I am open for suggestions. Thanks for reviewing.
>>
> 
> Here are my suggestions.
> 
> ---------------------
> 
> In Comparator:
> 
> 1. "Try to compare null with returned comparator will throw
> NullPointerException."
> 
> This sentence appears on Comparator.reverseOrder() and
> Comparator.naturalOrder().  I'm not sure it's worth fixing the
> sentence, because neither comparator strictly guarantees an NPE will
> be thrown.  Maybe just remove it?
> 

It's guaranteed as the Comparable not supporting null, and should throw
NPE with null.

Grammar errors pointed out are fixed.

Cheers,
Henry