hg: lanai/lanai: 2 new changesets

[Alexey Ushakov]

>> We are now building Lanai on our internal build servers on a nightly basis
>> and they use MacOS 10.13.6, Xcode 10.1, and the 10.14 SDK.
>> We should keep things to what builds there for now.

Yes, I agree that we need to have a stable build environment. However, I think that it’s important to discover and try new features from Metal to improve performance and architecture of the new rendering pipeline. So, I suggest to have such features available at least under some compile time checks.

Best Regards,
Alexey

> On 6 Nov 2019, at 12:06, Artem Bochkarev <artem.bochkarev at jetbrains.com> wrote:
> 
> Just FYI:
> 
>> I could not find any reference to the undefined type in any apple docs.
> You can find it here:
> https://developer.apple.com/documentation/metal/mtltextureswizzle?language=objc
> 
> On Tue, Nov 5, 2019 at 5:22 PM Philip Race <philip.race at oracle.com> wrote:
> 
>> Please explain this a bit more. I'd wondered if it were a later xcode /
>> SDK but
>> I could not find any reference to the undefined type in any apple docs.
>> Can you provide one ? I'd have thought it an SDK thing not an xcode one but
>> Apple seem to mix SDK and Xcode (the IDE) in a way that I find difficult
>> to dissect.
>> 
>> We are now building Lanai on our internal build servers on a nightly basis
>> and they use MacOS 10.13.6, Xcode 10.1, and the 10.14 SDK.
>> We should keep things to what builds there for now.
>> 
>> If this can work by specifying you want to keep to 10.14 SDK
>> functionality whilst using X code 11
>> that might be OK, but only if the code runs correctly on 10.13 ...
>> 
>> If we go outside what JDK currently uses to build, and what we support
>> to run,
>> that should not just be communicated via a push.
>> Upfront discussion and planning is needed.
>> 
>> -phil.
>> 
>> 
>> 
>> On 11/5/19, 4:37 AM, Alexey Ushakov wrote:
>>> Thanks, for handling this, Phil.
>>> 
>>> Actually the build failure was caused by different build environments
>> used in our development (Xcode 11) and build servers on your side (Xcode
>> 10?). We’re going to add some compile time logic to handle this.
>>> 
>>> Best Regards,
>>> Alexey
>>> 
>>>> On 4 Nov 2019, at 23:21, Phil Race<philip.race at oracle.com>  wrote:
>>>> 
>>>> I backed out the commit and verified the build.
>>>> 
>>>> Also note
>>>> 1) Bugs in this project need to be manually resolved as fixed.
>>>> 2) It is not customary to re-use the same bug ID as you have done below
>>>> for multiple commits. These don't get squashed like in the git model.
>>>> 
>>>> In this case however I think it can be re-used one last time to re-fix
>>>> the functionality including the missing file.
>>>> 
>>>> -phil.
>>>> 
>>>> 
>>>> On 11/4/19 11:24 AM, Phil Race wrote:
>>>>> The 2nd of these changes has broken the build :-
>>>>> 
>> lanai/open/src/java.desktop/macosx/native/libawt_lwawt/java2d/metal/MTLBlitLoops.m:224:13:
>> error: use of undeclared identifier 'MTLTextureSwizzleChannels'
>>>>>             MTLTextureSwizzleChannels swizzle =
>> MTLTextureSwizzleChannelsMake(
>>>>> 
>>>>> I am supposing you forgot to push a new file.
>>>>> If you can't fix this right now I'll back out the change.
>>>>> 
>>>>> -phil.
>>>>> 
>>>>> On 11/1/19 7:28 AM, alexey.ushakov at jetbrains.com wrote:
>>>>>> Changeset: b87de4164e02
>>>>>> Author:    abochkarev
>>>>>> Date:      2019-11-01 17:23 +0300
>>>>>> URL: https://hg.openjdk.java.net/lanai/lanai/rev/b87de4164e02
>>>>>> 
>>>>>> 8233039: minor code cleanup
>>>>>> 
>>>>>> minor simplification for MTLContext.createRenderEncoder, fixed
>> logging utils
>>>>>> 
>>>>>> !
>> src/java.desktop/macosx/native/libawt_lwawt/java2d/metal/MTLContext.m
>>>>>> ! src/java.desktop/macosx/native/libawt_lwawt/java2d/metal/MTLUtils.m
>>>>>> 
>>>>>> Changeset: a1fc001392fd
>>>>>> Author:    abochkarev
>>>>>> Date:      2019-11-01 17:25 +0300
>>>>>> URL: https://hg.openjdk.java.net/lanai/lanai/rev/a1fc001392fd
>>>>>> 
>>>>>> 8233039: support different raster formats (for SwToTexture blit)
>>>>>> 
>>>>>> * supported flag SurfaceData.isOpaue
>>>>>> * added implementation for missing composite rules (some combinations
>> of parameters and extra-alpha can't be supported with CAD-multipliers, need
>> to reimplement via shaders)
>>>>>> 
>>>>>> !
>> src/java.desktop/macosx/native/libawt_lwawt/java2d/metal/MTLBlitLoops.m
>>>>>> !
>> src/java.desktop/macosx/native/libawt_lwawt/java2d/metal/MTLContext.m
>>>>>> !
>> src/java.desktop/macosx/native/libawt_lwawt/java2d/metal/MTLPipelineStatesStorage.h
>>>>>> !
>> src/java.desktop/macosx/native/libawt_lwawt/java2d/metal/MTLPipelineStatesStorage.m
>>>>>> !
>> src/java.desktop/macosx/native/libawt_lwawt/java2d/metal/MTLVertexCache.m
>>>>>> 
>>