hg: lanai/lanai: 8230958: AA Geometry rendering is not supported in metal

[Ajit Ghaisas]

Hi Alexey,

  I have fixed the J2DDemo breakage with a workaround.
  https://hg.openjdk.java.net/lanai/lanai/rev/7acbc7a0b1cb

  Correct fix would be to maintain compState in MTLContext in a proper way. That will result in selection of appropriate RenderPipelineState on render encoder.

Regards,
Ajit

> On 18-Sep-2019, at 6:38 AM, Alexey Ushakov <alexey.ushakov at jetbrains.com> wrote:
> 
> Hi Ajit,
> 
> Thanks for reporting this. The work is in progress (though the case you’ve mentioned is not reproducible on my dev environment).
> 
> Anyway I’ll try to figure out what’s wrong and fix it ASAP.
> 
> Best Regards,
> Alexey
> 
>> On 15 Sep 2019, at 22:58, Ajit Ghaisas <ajit.ghaisas at oracle.com> wrote:
>> 
>> Hi Alexey,
>> 
>> I hope this is still work in progress & not complete yet.
>> This change has broken sanity of J2DDemo - with or without anti-aliasing.
>> 
>> To test - 
>> 1) launch J2DDemo -
>> /Users/AGHAISAS/jdk_workspace/lanai_ws/one/lanai/build/macosx-x86_64-server-release/images/jdk/bin/java -Dsun.java2d.metal=true  -jar /Users/AGHAISAS/jdk_workspace/lanai_ws/one/lanai/build/macosx-x86_64-server-release/images/jdk/demo/jfc/J2Ddemo/J2Ddemo.jar -antialias=false
>> 2) Click on ‘Lines’ tab - J2DDemo app crashes with this message -
>> 
>> -[MTLIOAccelRenderCommandEncoder bindEmulationArguments]:127: failed assertion `No render pipeline state bound'
>> Abort trap: 6
>> 
>> Changing antialias=true also results in a crash.
>> 
>> We need to either handle the case where the render pipeline is set OR add a TODO log & set a dummy render pipeline state.
>> 
>> Regards,
>> Ajit
>> 
>>> On 13-Sep-2019, at 11:47 PM, alexey.ushakov at jetbrains.com wrote:
>>> 
>>> Changeset: 395749d2f52c
>>> Author:    avu
>>> Date:      2019-09-13 21:17 +0300
>>> URL:       https://hg.openjdk.java.net/lanai/lanai/rev/395749d2f52c
>>> 
>>> 8230958: AA Geometry rendering is not supported in metal
>>> 
>>> Supported flat color fills in AA rendering mode
>>> 
>>> ! src/java.desktop/macosx/native/libawt_lwawt/awt/common.h
>>> ! src/java.desktop/macosx/native/libawt_lwawt/awt/shaders.metal
>>> ! src/java.desktop/macosx/native/libawt_lwawt/java2d/metal/MTLContext.m
>>> ! src/java.desktop/macosx/native/libawt_lwawt/java2d/metal/MTLPaints.m
>>> 
>> 
>