FYI: 8242079: Update RenderPerf LCD Test to ensure LCD code path is used
Alexey Ushakov
alexey.ushakov at jetbrains.com
Fri Apr 3 10:24:38 UTC 2020
> I guess build.xml is used by ant, right?
Yes, that’s right.
>> Also, It would be better for future maintenance to extract common part from RenderPerfLCDTest and RenderPerfTest and put to the separate class.
What is about this part? Do you want to do refactoring by yourself or I can handle this?
Best Regards,
Alexey
> On 3 Apr 2020, at 13:03, Prasanta Sadhukhan <prasanta.sadhukhan at oracle.com> wrote:
>
> Hi Alexey,
>
> I guess build.xml is used by ant, right? I normally used "make" so forgot to update the xml. Also, I am not very conversant with xml paradighm but, I will try to update that as well soon.
>
> Regards
> Prasanta
> On 03-Apr-20 3:04 PM, Alexey Ushakov wrote:
>> Hi Prasanta,
>>
>> Could you update src/demo/share/java2d/RenderPerfTest/build.xml as well. Also, It would be better for future maintenance to extract common part from RenderPerfLCDTest and RenderPerfTest and put to the separate class.
>>
>> Best Regards,
>> Alexey
>>
>>> On 3 Apr 2020, at 12:09, Prasanta Sadhukhan <psadhukhan at openjdk.java.net> wrote:
>>>
>>> t is found that RenderPerf Test testTextBubblesLCD follows grayscale code path and not LCD code path so it will test
>>> correct LCD text performance.
>>>
>>> -------------
>>>
>>> Commit messages:
>>> - 8242079: Update RenderPerf LCD Test to ensure LCD code path is used
>>> - 8242079: Update RenderPerf LCD Test to ensure LCD code path is used
>>>
>>> Changes: https://git.openjdk.java.net/lanai/pull/20/files
>>> Webrev: https://webrevs.openjdk.java.net/lanai/20/webrev.00
>>> Issue: https://bugs.openjdk.java.net/browse/JDK-8242079
>>> Stats: 381 lines in 2 files changed: 379 ins; 0 del; 2 mod
>>> Patch: https://git.openjdk.java.net/lanai/pull/20.diff
>>> Fetch: git fetch https://git.openjdk.java.net/lanai pull/20/head:pull/20
>>>
>>> PR: https://git.openjdk.java.net/lanai/pull/20
More information about the lanai-dev
mailing list