RFR: 8250778: [Lanai] Primitives rendered with metal on non-retina monitor are different as compared to OpenGL

Ajit Ghaisas ajit.ghaisas at oracle.com
Thu Jul 30 18:12:29 UTC 2020


Hi,

As Denis had created his PRs 2 days ago (but stuck in the process), I will back out my changes and let him integrate his PRs.

Regards,
Ajit

> On 30-Jul-2020, at 1:02 PM, Ajit Ghaisas <ajit.ghaisas at oracle.com> wrote:
> 
> Hi Alexey,
> 
>   Oh.. I did not check these PRs before pushing my fix :(
> 
>   I was working on XOR mode and it was failing for uiScale=1.0. Hence, I root caused it and filed a new bug to fix it.
> 
> Regards,
> Ajit
> 
>> On 30-Jul-2020, at 12:57 PM, Alexey Ushakov <alexey.ushakov at jetbrains.com> wrote:
>> 
>> Hi Ajit, 
>> 
>> Looks like you did the same thing that Denis has submitted via pull requests. https://github.com/openjdk/lanai/pulls <https://github.com/openjdk/lanai/pulls>
>> But for some reason he is unable to get through the process.
>> 
>> Best Regards,
>> Alexey
>> 
>> 
>>> On 30 Jul 2020, at 10:00, Ajit Ghaisas <aghaisas at openjdk.java.net> wrote:
>>> 
>>> Issue : https://bugs.openjdk.java.net/browse/JDK-8250778
>>> Fix :  Replicated pixel adjustments in Metal code similar to that of OpenGL code. Also, implemented DRAW_PIXEL
>>> operation.
>>> 
>>> -------------
>>> 
>>> Commit messages:
>>> - fix primitive rendering
>>> 
>>> Changes: https://git.openjdk.java.net/lanai/pull/70/files
>>> Webrev: https://webrevs.openjdk.java.net/lanai/70/webrev.00
>>> Issue: https://bugs.openjdk.java.net/browse/JDK-8250778
>>> Stats: 116 lines in 2 files changed: 93 ins; 1 del; 22 mod
>>> Patch: https://git.openjdk.java.net/lanai/pull/70.diff
>>> Fetch: git fetch https://git.openjdk.java.net/lanai pull/70/head:pull/70
>>> 
>>> PR: https://git.openjdk.java.net/lanai/pull/70
>> 
> 



More information about the lanai-dev mailing list