RFR: 8261547: Minor memory leak reported for Metal Rendering pipeline [v2]

Kevin Rushforth kcr at openjdk.java.net
Thu Feb 11 17:06:46 UTC 2021


On Thu, 11 Feb 2021 13:31:59 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

>> Memory leak fix for couple of strings.
>
> Prasanta Sadhukhan has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains two commits:
> 
>  - Merge master
>  - Memory leak fix

Changes requested by kcr (Committer).

src/java.desktop/macosx/native/libawt_lwawt/java2d/metal/MTLGraphicsConfig.m line 120:

> 118:     NSMutableArray * retArray = [NSMutableArray arrayWithCapacity:3];
> 119:     [retArray addObject: [NSNumber numberWithInt: (int)displayID]];
> 120:     NSString *str = JNU_GetStringPlatformChars(env, shadersLibName, 0);

This should be of type `char *` not `NSString *`

src/java.desktop/macosx/native/libawt_lwawt/java2d/metal/MTLGraphicsConfig.m line 153:

> 151:     NSMutableArray * retArray = [NSMutableArray arrayWithCapacity:3];
> 152:     [retArray addObject: [NSNumber numberWithInt: (int)displayID]];
> 153:     NSString *str = JNU_GetStringPlatformChars(env, mtlShadersLib, 0);

`char *`

-------------

PR: https://git.openjdk.java.net/lanai/pull/182


More information about the lanai-dev mailing list