RFR: 8261703: Many java/awt/ tests fail with Metal API Validation Stencil PixelFormat error [v2]

Jayathirth D V jdv at openjdk.java.net
Wed Feb 17 13:28:16 UTC 2021


> In LCD text rendering we get texture encoder which takes same shader parameters as LCD and then update its pipeline state locally and not in centralized MTLPaints. In cases where we use stencil based rendering and then move to LCD we will have invalid stencil state(Eventhough it doesnt change LCD text rendering output) because we override pipeline state locally after getting encoder. Moving LCD encoder state management to EncoderManager will resolve the issue when Metal API Validation is enabled.

Jayathirth D V has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision:

 - Merge branch 'master' into JDK-8261703_LCD_stencil_error
 - Initial fix

-------------

Changes:
  - all: https://git.openjdk.java.net/lanai/pull/194/files
  - new: https://git.openjdk.java.net/lanai/pull/194/files/43dc5845..d6a3aeee

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=lanai&pr=194&range=01
 - incr: https://webrevs.openjdk.java.net/?repo=lanai&pr=194&range=00-01

  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.java.net/lanai/pull/194.diff
  Fetch: git fetch https://git.openjdk.java.net/lanai pull/194/head:pull/194

PR: https://git.openjdk.java.net/lanai/pull/194


More information about the lanai-dev mailing list