RFR: 8261891: sanity/client/SwingSet/src/EditorPaneDemoTest.java fails with Metal API Validation

[Alexey Ushakov]

On Wed, 24 Feb 2021 03:30:24 GMT, Jayathirth D V <jdv at openjdk.org> wrote:

>> Refactored AA shader usage. Performed end of AAshader encoder for incompatible rendering modes
>
> src/java.desktop/macosx/native/libawt_lwawt/java2d/metal/EncoderManager.m line 370:
> 
>> 368:   if (_encoder != nil) {
>> 369:     if (_destination != dest || renderOptions->isAA != _encoderStates.aa ||
>> 370:             renderOptions->isAAShader != _encoderStates.aaShader) {
> 
> Hi Alexey,
> 
> Is there any performance impact because of ending the encoder on switch?
> 
> Thanks,
> Jay

Hi Jay,

Thanks for the comment. I didn’t find any difference at least with RenderPerfTest. However, looks like we don’t need to end the encoder here - the appropriate state will be recovered later in the code (by updatePipelineState method).

So, I’m going to remove this condition from the if statement.

Best Regards,
Alexey

-------------

PR: https://git.openjdk.java.net/lanai/pull/201