RFR: 8258754: Gracefully fallback to the OpenGL rendering pipeline if Metal rendering pipeline initialization fails [v9]

[Kevin Rushforth]

On Mon, 18 Jan 2021 10:24:21 GMT, Ajit Ghaisas <aghaisas at openjdk.org> wrote:

>> This implements fallback to the OpenGL rendering pipeline if Metal rendering pipeline initialization fails.
>> I have tested this fallback on 10.15.4 by stubbing code. We need real testing on a system where Metal is not available.
>
> Ajit Ghaisas has updated the pull request incrementally with one additional commit since the last revision:
> 
>   fix review comment

Looks good. My earlier comment is still partially valid, so I repeated it in the context of the latest review. It can be done in a follow-up.

src/java.desktop/macosx/classes/sun/java2d/macos/MacOSFlags.java line 114:

> 112:                         }
> 113:                     } else if (metalState == PropertyState.ENABLED) {
> 114:                         if (oglState == PropertyState.DISABLED || oglState == PropertyState.UNSPECIFIED) {

This check is redundant. By the time we get here, the two flags cannot possibly be the same value, so you could simplify this by removing this check. That could be done as a follow-up.

-------------

Marked as reviewed by kcr (Committer).

PR: https://git.openjdk.java.net/lanai/pull/147