git: openjdk/leyden: created branch premain based on the branch computed-constants containing 1 unique commit

[Dan Heidinga]

I'm reading through the code in the premain branch (which looks very cool
though I'm still wrapping my head around it) and had an early question
about the cdsHeapVerifier.cpp:

> void CDSHeapVerifier::add_static_obj_field(InstanceKlass* ik, oop field,
Symbol* name) {
>   if (field->klass() == vmClasses::MethodType_klass() ||
>       field->klass() == vmClasses::LambdaForm_klass()) {
>     // LambdaForm and MethodType are non-modifiable and are not tested
for object equality, so
>     // it's OK if the static fields are reinitialized at runtime with
alternative instances.
>     // (TODO: double check is this is correct)
>     return;
>   }

I can't speak to LambdaForms but MethodTypes definitely rely on equality
for correct behaviour when invoking - see Invokers.java::checkExactType
which is part of every MethodHandles.invokeExact call.  Is this kind of
equality test something this code should be concerned about?

I may be looking at this in the wrong way but thought I'd chime in as I
read the diff in case this helps.

--Dan

On Tue, Aug 8, 2023 at 2:30 PM duke <duke at openjdk.org> wrote:

> The following commits are unique to the premain branch:
> ========================================================
> 626b62aa: Initial commit
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.org/pipermail/leyden-dev/attachments/20230808/4f020ede/attachment.htm>