RFR: 8335358: [premain] Explore alternative ways to trigger the end of training run [v11]

[Mat Carter]

On Wed, 13 Nov 2024 22:18:31 GMT, Mat Carter <macarte at openjdk.org> wrote:

>> src/hotspot/share/runtime/runtimeUpcallNop.cpp line 45:
>> 
>>> 43: bool RuntimeUpcallNop::filter_method_callback(MethodDetails& methodDetails)
>>> 44: {
>>> 45:   return false;
>> 
>> Shouldn't this be returning true to enable it for all methods as per the documentation for AddRuntimeUpcallsNOP in globals.hpp?
>
> Thanks for pointing that out; I've updated the AddRuntimeUpcallsNOP to a string that is of the format "=[onMethodEntry|onMethodExit]:[all|none]" allowing us to test (a) mulitple upcalls ,(b) test onMethodExit (that it currently asserts), (c) have the NOP upcall do nothing, but either install an upcall on no methods or all methods

So now the filter will use the value from the string 'none' (false) or 'all' (true) for the filter result

-------------

PR Review Comment: https://git.openjdk.org/leyden/pull/21#discussion_r1841261213