RFR: 8335358: [premain] Explore alternative ways to trigger the end of training run [v11]

[Mat Carter]

On Thu, 14 Nov 2024 04:16:10 GMT, Ioi Lam <iklam at openjdk.org> wrote:

>> Mat Carter has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 43 additional commits since the last revision:
>> 
>>  - Enhanced upcall system testing options (based on PR feedback)
>>  - Removing unused includes
>>  - Remove cds include, no longer required after refactor
>>  - merge issue
>>  - fix merge issues
>>  - Update other platforms
>>  - Merge branch 'premain' into macarte-endtraining
>>  - Merge pull request #2 from macarte/macarte-endtraining-refactor
>>    
>>    Macarte endtraining refactor
>>  - minor edits
>>  - small changes based on PR review
>>  - ... and 33 more: https://git.openjdk.org/leyden/compare/afefb1ec...9c3cdf78
>
> src/hotspot/share/cds/cdsEndTrainingUpcall.cpp line 86:
> 
>> 84: 
>> 85: bool CDSEndTrainingUpcall::filter_method_callback(MethodDetails& methodDetails)
>> 86: {
> 
> The HotSpot convention would be to use `method_details` instead of `methodDetails` for the names of fields, parameters and local variables.
> 
> See https://github.com/openjdk/jdk/blob/master/doc/hotspot-style.md#naming

Thanks, I've corrected all camelCase to lowercase_lowercase format

-------------

PR Review Comment: https://git.openjdk.org/leyden/pull/21#discussion_r1850832635