RFR: 8335358: [premain] Explore alternative ways to trigger the end of training run [v3]

[Mat Carter]

On Wed, 11 Sep 2024 22:24:53 GMT, Mat Carter <macarte at openjdk.org> wrote:

>> AOT training can be ended using either
>> 
>> - -XX: AOTEndTrainingOnMethodEntry =Hello.someMethod [same syntax as CompileOnly]
>> - -XX: AOTEndTrainingOnMethodEntry =Hello.someMethod,Hello.someOtherMethod,count=42
>> - jcmd <pid> AOT.end_training
>> 
>> supports arm64 and x64
>> 
>> note: the AOTEndTrainingOnMethodEntry is ignored when CDSPreImage is specified; this is needed as the phase2 forked java process is passed all phase1 flags along with the -XX:CDSPreImage, but we don't want to run the trigger code in this phase (there may be a better way to handle this state or simply remove the flag from the forked process)
>> 
>> JBS Issue: https://bugs.openjdk.org/browse/JDK-8335358
>
> Mat Carter has updated the pull request incrementally with one additional commit since the last revision:
> 
>   another missing include that impacts some build configurations

src/hotspot/share/services/diagnosticCommand.hpp line 410:

> 408:     static const JavaPermission permission() {
> 409:     JavaPermission p = {"java.lang.management.ManagementPermission",
> 410:                         "monitor", nullptr};

Should this be 'monitor' or 'control' (or something else)?

-------------

PR Review Comment: https://git.openjdk.org/leyden/pull/21#discussion_r1757301959