RFR: 8335358: [premain] Explore alternative ways to trigger the end of training run [v5]

[Mat Carter]

On Tue, 17 Sep 2024 04:29:01 GMT, Ioi Lam <iklam at openjdk.org> wrote:

>> Mat Carter has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   removed extra space left over from reverted change
>
> src/hotspot/share/opto/parse1.cpp line 1215:
> 
>> 1213:   }
>> 1214: 
>> 1215:   if (CDSConfig::is_dumping_preimage_static_archive_with_triggers() && method()->is_end_training_trigger()) {
> 
> Do we come here also if `method()` is being inlined by C2?

It does, I tested inlining manually and proved that the method was inlined and still triggering, I'll see if I can add a test case so that if the inlining code path changes the test failure will direct us to add the appropriate code to the new code path

-------------

PR Review Comment: https://git.openjdk.org/leyden/pull/21#discussion_r1763632869