RFR: 8349814: [leyden] Reduce uncommon traps in preload code [v9]

Vladimir Ivanov vlivanov at openjdk.org
Wed Apr 2 17:25:29 UTC 2025


On Wed, 2 Apr 2025 09:02:51 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

>> Preload code is the C2 code we load very early, before it gets substituted by more advanced C2 code. We are seeing lots of uncommon traps from the preloaded code, though, which invalidates it too early. We can do precompile code without uncommon traps to alleviate this. 
>> 
>> Additional testing:
>>  - [x] Ad-hoc perf tests (see comment below)
>>  - [x] Linux x86_64 server fastdebug, `runtime/cds`
>
> Aleksey Shipilev has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 18 additional commits since the last revision:
> 
>  - Back to integrateable form
>  - Merge branch 'premain' into JDK-8349814-preload-avoid-uncommon-traps
>  - Also a script
>  - Specialize ciTypeFlow traps
>  - More debugging on ciTypeFlow side
>  - Merge branch 'premain' into JDK-8349814-preload-avoid-uncommon-traps
>  - Merge branch 'premain' into JDK-8349814-preload-avoid-uncommon-traps
>  - Merge branch 'premain' into JDK-8349814-preload-avoid-uncommon-traps
>  - Merge logging
>  - Better logging levels
>  - ... and 8 more: https://git.openjdk.org/leyden/compare/67e1f0ae...f8337bee

Looks good.

-------------

Marked as reviewed by vlivanov (Committer).

PR Review: https://git.openjdk.org/leyden/pull/38#pullrequestreview-2737033905


More information about the leyden-dev mailing list