RFR: 8347755: Support static library in jmod [v6]

Jiangli Zhou jiangli at openjdk.org
Thu Apr 17 22:26:02 UTC 2025


On Fri, 14 Mar 2025 18:07:05 GMT, Henry Jen <henryjen at openjdk.org> wrote:

>>> I didn't particularly filter-out or move this file because I wonder if this file serve as a manifest. 
>> 
>> No, it doesn't, it's just an implementation specific detail of the build system.
>> 
>>> Otherwise, we could do something like how we process other folders like modules_libs. `jmod --exclude` could be a solution as well.
>> 
>> No, no. We should just don't mix temporary support files with the proper output files.
>
>> > I didn't particularly filter-out or move this file because I wonder if this file serve as a manifest.
>> 
>> No, it doesn't, it's just an implementation specific detail of the build system.
>> 
> 
> I know the original intention of this is not for that. What I am asking is if we should have such a manifest or hints for user? Similar to pkg-config.
> 
>> > Otherwise, we could do something like how we process other folders like modules_libs. `jmod --exclude` could be a solution as well.
>> 
>> No, no. We should just don't mix temporary support files with the proper output files.
> 
> That I agree.

> @slowhog This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@slowhog Could you please add a comment to make sure your PR is not closed? Thanks

-------------

PR Comment: https://git.openjdk.org/leyden/pull/46#issuecomment-2814127775


More information about the leyden-dev mailing list