RFR: Cleaner GHA build of hermetic-java-runtime branch

[Jiangli Zhou]

On Mon, 28 Apr 2025 13:04:49 GMT, Severin Gehwolf <sgehwolf at openjdk.org> wrote:

> Please review this simple PR which fixes build issues seen on GHA. Before this PR we see build failures in various Linux cross-builds and windows builds. This PR should fix those. Note: There are still GHA test failures, but at least we can build the branch on the main 3 platforms.
> 
> Thoughts?

src/hotspot/share/utilities/globalDefinitions.hpp line 1031:

> 1029: // Redefine Thread as BaseThread to avoid duplicate symbol issues for
> 1030: // JDK static builds. See runtime/thread.hpp for Thread class.
> 1031: #define Thread HotspotBaseThread

This change and the one in src/hotspot/os_cpu/linux_aarch64/threadLS_linux_aarch64.S are related to https://bugs.openjdk.org/browse/JDK-8311846. There were discussions on https://github.com/openjdk/jdk/pull/17456 (closed without integrating), but we don't yet have a acceptable solution moving forward.

Should we leave the patch in the branch until we identify a proper solution?

src/java.base/share/native/launcher/main.c line 40:

> 38: 
> 39: // Windows doesn't have PATH_MAX. It's MAX_PATH instead.
> 40: #ifdef _WIN32

Thanks. Checking https://learn.microsoft.com/en-us/cpp/c-language/cpp-integer-limits?view=msvc-170, PATH_MAX is not defined for Windows limits.h.

-------------

PR Review Comment: https://git.openjdk.org/leyden/pull/63#discussion_r2064348725
PR Review Comment: https://git.openjdk.org/leyden/pull/63#discussion_r2064381059