RFR: Cleaner GHA build of hermetic-java-runtime branch [v2]
Severin Gehwolf
sgehwolf at openjdk.org
Wed Apr 30 17:12:27 UTC 2025
On Wed, 30 Apr 2025 15:02:53 GMT, Jiangli Zhou <jiangli at openjdk.org> wrote:
>> Severin Gehwolf has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:
>>
>> - Revert globalDefinitions.hpp change
>> - Merge branch 'hermetic-java-runtime' into fix_build_issues_hermetic
>> - Cleaner GHA build of hermetic-java-runtime branch
>
> src/hotspot/os_cpu/linux_aarch64/threadLS_linux_aarch64.S line 1:
>
>> 1: // Copyright (c) 2015, 2022, Red Hat Inc. All rights reserved.
>
> The src/hotspot/os_cpu/linux_aarch64/threadLS_linux_aarch64.S also needs to be reverted. It causes the linux-cross-build aarch64 build failures:
>
>
> ...
> /usr/lib/gcc-cross/aarch64-linux-gnu/10/../../../../aarch64-linux-gnu/bin/ld: /home/runner/work/leyden/leyden/src/hotspot/os_cpu/linux_aarch64/threadLS_linux_aarch64.S:38: undefined reference to `Thread::_thr_current'
> collect2: error: ld returned 1 exit status
> * For target hotspot_variant-server_libjvm_objs_BUILD_LIBJVM_run_ld:
> /usr/lib/gcc-cross/aarch64-linux-gnu/10/../../../../aarch64-linux-gnu/bin/ld: /home/runner/work/leyden/leyden/build/linux-aarch64/hotspot/variant-server/libjvm/objs/threadLS_linux_aarch64.o: in function `JavaThread::aarch64_get_thread_helper()':
> /home/runner/work/leyden/leyden/src/hotspot/os_cpu/linux_aarch64/threadLS_linux_aarch64.S:34: undefined reference to `Thread::_thr_current'
> ...
Done.
-------------
PR Review Comment: https://git.openjdk.org/leyden/pull/63#discussion_r2069127406
More information about the leyden-dev
mailing list