RFR: Use method offset nmethods hash

Vladimir Kozlov kvn at openjdk.org
Thu Aug 14 00:51:29 UTC 2025


On Thu, 14 Aug 2025 00:40:30 GMT, Vladimir Kozlov <kvn at openjdk.org> wrote:

>> src/hotspot/share/code/aotCodeCache.cpp line 934:
>> 
>>> 932:       log_info(aot, codecache, nmethod)("Missing entry for '%s' (comp_level %d, hash: " UINT32_FORMAT_X_0 ")", target_name, (uint)comp_level, hash);
>>> 933: #ifdef ASSERT
>>> 934:     } else if (method() != entry->method()) {
>> 
>> As you said we can't use pointers (base could be different).
>> I suggest to keep original code here.
>
> May be add `assert(entry->id() == hash`

An other change could be preserving method's name in AOT cache only in debug VM for this compares. For printing we can get name from `entry->method()->name_and_sig_as_C_string()`.

-------------

PR Review Comment: https://git.openjdk.org/leyden/pull/91#discussion_r2274951502


More information about the leyden-dev mailing list