RFR: Use method offset as the hash for storing nmethods [v3]
Ashutosh Mehra
asmehra at openjdk.org
Fri Aug 15 04:42:28 UTC 2025
On Thu, 14 Aug 2025 22:22:36 GMT, Vladimir Kozlov <kvn at openjdk.org> wrote:
> Lets do it in separate changes, this is not urgent.
Ok
> Crashes in AOT tests in AOTCodeEntry::method()
Yes you are right, the AOTCodeEntry::method() would work only in production run because of SharedBaseAddress. We can fix it in two ways:
1. Remove the usage of method() in assembly phase and add assert in method() that it is being used in production run only. There are currently two usages of method() in assembly run, and both are for null checks.
2. Based on whether it is in assembly run or prod run, use `MetaspaceShared::requested_base_address()` or `SharedBasedAddress`.
I am inclined to 1 because current usage of method() in assembly phase is only for null checks which should always be false.
-------------
PR Comment: https://git.openjdk.org/leyden/pull/91#issuecomment-3190591377
More information about the leyden-dev
mailing list