RFR: Use method offset as the hash for storing nmethods [v4]

Vladimir Kozlov kvn at openjdk.org
Sat Aug 16 15:06:31 UTC 2025


On Fri, 15 Aug 2025 05:45:32 GMT, Ashutosh Mehra <asmehra at openjdk.org> wrote:

>> Currently AOTCodeEntry for nmethod uses a hash obtained from the method holder's name, method name and signature.   This is not very reliable.  With https://github.com/openjdk/leyden/pull/90, AOTCodeEntry is always linked to its corresponding Method, so we should be able to use the Method pointer as the hash for AOTCodeEntries for nmethod. However, the problem with pointers are not stable across runs. So instead of the pointer, we can use the offset of the Method in AOTCache. This should work because the Method is guaranteed to be in AOTCache.
>> This PR updates the code to use Method offset as the hash for AOTCodeEntries for nmethods.
>
> Ashutosh Mehra has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Use AOTCodeEntry::method() only in production run
>   
>   Signed-off-by: Ashutosh Mehra <asmehra at redhat.com>

My testing passed.

-------------

Marked as reviewed by kvn (Committer).

PR Review: https://git.openjdk.org/leyden/pull/91#pullrequestreview-3125893230


More information about the leyden-dev mailing list