RFR: 8349539: [leyden] Allow dumping nmethods that reference archived hidden klasses [v2]

[Aleksey Shipilev]

On Thu, 6 Feb 2025 22:00:38 GMT, Vladimir Ivanov <vlivanov at openjdk.org> wrote:

> But there are non-default modes where it still matters (`UseMetadataPointers == true`).

FWIW, I believe `UseMetadataPointers` is `true` by default. Turning it off starts to fail `runtime/cds`.

>  I suggest to keep klass->is_hidden() check, but move it down to guard symbolic resolution case.

Could you point me where exactly? I think there is a fair amount of symmetry against the hidden method checks here, so I moved the check to the same place:
https://github.com/openjdk/leyden/blob/7bf2c6ae009bdf13bf0717c13aab4a47aa9c8808/src/hotspot/share/code/SCCache.cpp#L1780-L1783

-------------

PR Comment: https://git.openjdk.org/leyden/pull/33#issuecomment-2647461079