Integrated: 8349748: [leyden] ciEnv::register_method should lock the correct queue lock

Aleksey Shipilev shade at openjdk.org
Tue Feb 11 16:28:23 UTC 2025


On Mon, 10 Feb 2025 17:53:39 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

> Mainline code locks `MethodCompileQueue_lock` in `ciEnv::register_method`. But with Leyden-s `UseGlobalCompileQueueLock = false`, we have separate locks, per compile queue. So it seems to stand to reason we should be locking those locks, not a global one.
> 
> I have not been able to attribute this gap to any bug or performance issue, but I think we better fix this proactively.

This pull request has now been integrated.

Changeset: 8125f60b
Author:    Aleksey Shipilev <shade at openjdk.org>
Committer: Vladimir Kozlov <kvn at openjdk.org>
URL:       https://git.openjdk.org/leyden/commit/8125f60b444f5e7bc0b36bfcdeb75fe9c14fdb91
Stats:     1 line in 1 file changed: 0 ins; 0 del; 1 mod

8349748: [leyden] ciEnv::register_method should lock the correct queue lock

Reviewed-by: vlivanov, kvn

-------------

PR: https://git.openjdk.org/leyden/pull/37


More information about the leyden-dev mailing list